Krazy2 Analysis of graphics/digikam (Revision = master-rev-c55df3991e)

Checksets = kde5,foss
Checkers Run = 54
Files Processed = 4406
Total Issues = 466 ...as of May 02 2024 17:17:13 CEST

• For File Type cmake
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for URLs not using transport encryption [insecurenet]...okay!
  4. Check for spelling errors [spelling]...okay!
• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type c++
  1. Check for methods that return 'const' refs in public classes [constref]...okay!
  2. Check for an acceptable copyright [copyright]...okay!
  3. Check for cpp macros and usage [cpp]...okay!
  4. Check for code that should be considered crashy. [crashy]...okay!
  5. Check single-char QString operations for efficiency [doublequote_chars]...okay!
  6. Check for unwanted doxygen tags in major versions [doxytags]...okay!
  7. Check public classes with private members or d-pointer issues [dpointer]...okay!
  8. Check for QString compares to "" [emptystrcompare]...okay!
  9. Check that file ends with a newline [endswithnewline]...okay!
  10. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  11. Check for problems with filenames [filenames]...okay!
  12. Check validity of i18n calls [i18ncheckarg]...OOPS! 464 issues found!
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: missing KUIT context marker line# 44,54,58,60,66,69,70,71,72,73,77,82,84,89,91,100,120,124,125,126,140,147,162,179,184,185,191,196,197,198,215,223,228,229,234,241,245,246,249,252,254 (41)
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 169,169,186,186,199,199,199 (7)
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 44,169,186,186,199,199,199 (7)
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: HTML tag 'i' is not advised with KUIT markup line# 58,66 (2)
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 58,66,66 (3)
      • /mnt/data2/devel/GIT/8.x/core/utilities/maintenance/maintenancedlg.cpp: HTML tag 'qt' is not advised with KUIT markup line# 44,58,66 (3)
      • /mnt/data2/devel/GIT/8.x/core/utilities/fuzzysearch/findduplicatesview.cpp: invalid semantic role @group line# 216 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/import/widgets/albumcustomizer.cpp: HTML tag 'b' is not advised with KUIT markup line# 75,75,75,75,75,75,75,75,75,75,75,75,75 (13)
      • /mnt/data2/devel/GIT/8.x/core/utilities/import/widgets/albumcustomizer.cpp: HTML tag 'p' is not advised with KUIT markup line# 75,75,75,75,75,75,75,75,75,75,75,75,75,75,75 (15)
      • /mnt/data2/devel/GIT/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: missing KUIT context marker line# 74,78,101,130 (4)
      • /mnt/data2/devel/GIT/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 74,78 (2)
      • /mnt/data2/devel/GIT/8.x/core/utilities/queuemanager/views/workflowdlg.cpp: HTML tag 'qt' is not advised with KUIT markup line# 74,78 (2)
      • /mnt/data2/devel/GIT/8.x/core/utilities/searchwindow/searchmodificationhelper.cpp: missing KUIT context marker line# 72,109,142 (3)
      • /mnt/data2/devel/GIT/8.x/core/utilities/setup/setupgeolocation.cpp: missing KUIT context marker line# 103,131 (2)
      • /mnt/data2/devel/GIT/8.x/core/utilities/setup/setupgeolocation.cpp: HTML tag 'a' is not advised with KUIT markup line# 114 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/setup/collections/setupcollectionview.cpp: missing KUIT context marker line# 632,698,862,870,935,940,945,982,1032,1128,1133,1138,1157,1185,1213,1248,1253,1258,1554,1626,1630,1717,1723,1724,1725 (25)
      • /mnt/data2/devel/GIT/8.x/core/utilities/geolocation/geoiface/core/geopluginaboutdlg.cpp: missing KUIT context marker line# 96 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/geolocation/geoiface/core/geopluginaboutdlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 96 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/geolocation/geoiface/bookmark/bookmarksmngr.cpp: missing KUIT context marker line# 46,88,134,141,148,813,936,948,955,962,963,973 (12)
      • /mnt/data2/devel/GIT/8.x/core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp: missing KUIT context marker line# 86,93,98,217,220,352,411 (7)
      • /mnt/data2/devel/GIT/8.x/core/utilities/geolocation/geoiface/backends/mapbackend.cpp: missing KUIT context marker line# 58,68,149,162,178 (5)
      • /mnt/data2/devel/GIT/8.x/core/utilities/imageeditor/main/imagewindow.cpp: missing KUIT context marker line# 187,191,362,491,575,690,943,1114,1139,1171 (10)
      • /mnt/data2/devel/GIT/8.x/core/utilities/imageeditor/main/imagewindow.cpp: HTML tag 'qt' is not advised with KUIT markup line# 1217 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/imageeditor/main/imagewindow.cpp: HTML tag 'b' is not advised with KUIT markup line# 1217 (1)
      • /mnt/data2/devel/GIT/8.x/core/utilities/advancedrename/advancedrenameprocessdialog.cpp: HTML tag 'b' is not advised with KUIT markup line# 66,215 (2)
      • /mnt/data2/devel/GIT/8.x/core/utilities/advancedrename/advancedrenameprocessdialog.cpp: missing KUIT context marker line# 66,81,156,215 (4)
      • /mnt/data2/devel/GIT/8.x/core/showfoto/main/showfoto_open.cpp: missing KUIT context marker line# 303,326 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/inaturalist/inattalker.cpp: missing KUIT context marker line# 568,570,1928 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/box/boxtalker.cpp: missing KUIT context marker line# 429,453 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/box/boxwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 252 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/filetransfer/ftimportwidget.cpp: missing KUIT context marker line# 56,67,101 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/filetransfer/ftimportwindow.cpp: missing KUIT context marker line# 139 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/filetransfer/ftexportwindow.cpp: missing KUIT context marker line# 187 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/imgur/imgurwindow.cpp: HTML tag 'i' is not advised with KUIT markup line# 242 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/imgur/imgurwindow.cpp: missing KUIT context marker line# 111,121,132,242,250,278,285 (7)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/twitter/twitterwindow.cpp: missing KUIT context marker line# 249,257,289,293,329,392,409,414 (8)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/twitter/twitterwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 256 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/google/gswindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 518,548,962,983,1031,1081,1284 (7)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/google/gdrive/gdtalker.cpp: missing KUIT context marker line# 350,416,447 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/flickr/flickrwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 849 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/flickr/flickrwindow.cpp: missing KUIT context marker line# 614,807,842,850 (4)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/pinterest/pwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 255 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/pinterest/pwindow.cpp: missing KUIT context marker line# 248,256,288,292,329,387,401,406 (8)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/pinterest/ptalker.cpp: missing KUIT context marker line# 495,521 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/filecopy/fcexportwindow.cpp: missing KUIT context marker line# 222 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/imageshack/imageshackwindow.cpp: missing KUIT context marker line# 237,241,269,327,341,414 (6)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/smugmug/smugwindow.cpp: missing KUIT context marker line# 441,450,488,521,525,670,759,762,795,798,879,893,918,984,997,1017 (16)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/smugmug/smugwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 669 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/dropbox/dbwindow.cpp: missing KUIT context marker line# 245,252,276,280,318,376,390,395 (8)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/dropbox/dbtalker.cpp: missing KUIT context marker line# 415,442 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/mediawiki/mediawikiwindow.cpp: missing KUIT context marker line# 302,338,359 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/mediawiki/mediawikitalker.cpp: missing KUIT context marker line# 115,119,157 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/onedrive/odwindow.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 251 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/webservices/onedrive/odtalker.cpp: missing KUIT context marker line# 447,471 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/import/dscanner/scandialog.cpp: missing KUIT context marker line# 68,212,225,241,292,300 (6)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/tools/calendar/wizard/calwizard.cpp: HTML tag 'br' is not advised with KUIT markup line# 220,235,242,242,242 (5)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/tools/calendar/wizard/calwizard.cpp: missing KUIT context marker line# 114,119,129,140,148,220,235,242,297,309,359,369 (12)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/tools/jalbum/wizard/jalbumoutputpage.cpp: missing KUIT context marker line# 70,74,81 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/tools/printcreator/wizard/advprintphotopage.cpp: missing KUIT context marker line# 501,515,956,961,1118,1343 (6)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/metadata/timeadjust/timeadjustdialog.cpp: missing KUIT context marker line# 104 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp: missing KUIT context marker line# 296 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/view/presentation/widgets/presentationctrlwidget.cpp: missing KUIT context marker line# 230,256 (2)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/view/slideshow/widgets/slidetoolbar.cpp: missing KUIT context marker line# 128,141,249,412 (4)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/generic/view/slideshow/common/slideshowloader.cpp: missing KUIT context marker line# 687 (1)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/bqm/metadata/assigncaptions/assigncaptions.cpp: missing KUIT context marker line# 97,105,112 (3)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: HTML tag 'b' is not advised with KUIT markup line# 76,94,94,94 (4)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: HTML tag 'p' is not advised with KUIT markup line# 76,76,94,94,94 (5)
      • /mnt/data2/devel/GIT/8.x/core/dplugins/bqm/metadata/assigntags/assigntags.cpp: missing KUIT context marker line# 86,91,92,93 (4)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/rawcameradlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 125,125,135,135 (4)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/rawcameradlg.cpp: missing KUIT context marker line# 125,135 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'i' is not advised with KUIT markup line# 90 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'p' is not advised with KUIT markup line# 90,90 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'b' is not advised with KUIT markup line# 90 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: missing KUIT context marker line# 68,90,111 (3)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'font' is not advised with KUIT markup line# 90 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/infodlg.cpp: HTML tag 'br' is not advised with KUIT markup line# 90 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dialogs/libsinfodlg.cpp: missing KUIT context marker line# 545,551,626 (3)
      • /mnt/data2/devel/GIT/8.x/core/libs/database/utils/ifaces/dio.cpp: missing KUIT context marker line# 345,855,860,866,871,876,881,886,891,896,901 (11)
      • /mnt/data2/devel/GIT/8.x/core/libs/database/utils/widgets/dbsettingswidget.cpp: unclosed <br>, close in place line# 301 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/imgqsort/imagequalityconfselector.cpp: missing KUIT context marker line# 70 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/engine/albummodificationhelper.cpp: HTML tag 'p' is not advised with KUIT markup line# 238,238,251,251 (4)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/engine/albummodificationhelper.cpp: missing KUIT context marker line# 238,251,290 (3)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/widgets/albumselectors.cpp: single adjective as message, probably ambiguous; explain what it refers to following the KUIT context marker line# 166,226 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'p' is not advised with KUIT markup line# 150,173,209,209,218,218,218,296,296,296,315,462,462,531,531,554,554,604,604,636,636,742 (22)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'br' is not advised with KUIT markup line# 296,296,315,315 (4)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/manager/albummanager_database.cpp: missing KUIT context marker line# 110,121,128,137,150,166,173,209,218,231,253,296,315,334,341,462,531,554,589,604,636,701,719,742 (24)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/manager/albummanager_database.cpp: unclosed <br>, close in place line# 137 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/album/manager/albummanager_database.cpp: HTML tag 'b' is not advised with KUIT markup line# 173,209,209,218,218,218,296,742 (8)
      • /mnt/data2/devel/GIT/8.x/core/libs/dplugins/webservices/wstooldialog.cpp: reported ambiguous message by translators; explain what it refers to following the KUIT context marker line# 55 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dplugins/webservices/wsselectuserdlg.cpp: missing KUIT context marker line# 60,82 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/dplugins/iface/dmetainfoiface.cpp: missing KUIT context marker line# 267 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/dplugins/widgets/dwizarddlg.cpp: missing KUIT context marker line# 68,69 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/dplugins/widgets/dplugindialog.cpp: missing KUIT context marker line# 71,72 (2)
      • /mnt/data2/devel/GIT/8.x/core/libs/widgets/text/spellcheckconfig.cpp: missing KUIT context marker line# 111 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/threadimageio/thumb/thumbnailloadthread.cpp: missing KUIT context marker line# 154 (1)
      • /mnt/data2/devel/GIT/8.x/core/libs/properties/captions/itemdescedittab.cpp: HTML tag 'p' is not advised with KUIT markup line# 320,320,363 (3)
      • /mnt/data2/devel/GIT/8.x/core/libs/properties/captions/itemdescedittab.cpp: HTML tag 'li' is not advised with KUIT markup line# 328,333,338,343,348,353,358 (7)
      • /mnt/data2/devel/GIT/8.x/core/libs/dimg/filters/curves/curvessettings.cpp: missing KUIT context marker line# 250,271 (2)
      • /mnt/data2/devel/GIT/8.x/core/app/main/digikamapp_import.cpp: HTML tag 'p' is not advised with KUIT markup line# 144 (1)
      • /mnt/data2/devel/GIT/8.x/core/app/main/digikamapp_import.cpp: missing KUIT context marker line# 144,173 (2)
      • /mnt/data2/devel/GIT/8.x/core/app/items/utils/itemviewutilities.cpp: missing KUIT context marker line# 228,353 (2)
      • /mnt/data2/devel/GIT/8.x/core/app/items/utils/itemviewutilities.cpp: HTML tag 'p' is not advised with KUIT markup line# 228 (1)
      • /mnt/data2/devel/GIT/8.x/core/app/views/stack/trashview.cpp: reported ambiguous message by translators; use context call to explain what it refers to line# 439 (1)
      • /mnt/data2/devel/GIT/8.x/core/app/views/utils/componentsinfodlg.cpp: missing KUIT context marker line# 231,248,268,285,303 (5)

      Make the translators' job easier and detect problems in the usage of the i18n() calls. When the fix is not clear, check the Techbase article at http://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy for more information.

  13. Check for proper include directives [includes]...okay!
  14. Check for inline methods in public classes [inline]...okay!
  15. Check for URLs not using transport encryption [insecurenet]...okay!
  16. Check for normalized SIGNAL and SLOT signatures [normalize]...okay!
  17. Check for assignments to QString::null or QString() [nullstrassign]...OOPS! 2 issues found!
      • /mnt/data2/devel/GIT/8.x/core/libs/settings/applicationsettings_p.h: => QString applicationIcon = QString();
      • /mnt/data2/devel/GIT/8.x/core/libs/settings/applicationsettings_p.h: line# 345 (1)

      Do not assign QString::null to a QString. Instead use the .clear() method. For example, "str = QString::null" becomes "str.clear()". When returning an empty string from a method use "return QString()" When passing an empty string use "QString()".

  18. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  19. Check for C++ operators that should be 'const' [operators]...okay!
  20. Check for postfix usage of ++ and -- [postfixop]...okay!
  21. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  22. Check for Qt methods that should be avoided [qmethods]...okay!
  23. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  24. Check for signals: and slots: [sigsandslots]...okay!
  25. Check for spelling errors [spelling]...okay!
  26. Check for improperly initialized global static objects [staticobjects]...okay!
  27. Check for strings used improperly or should be i18n. [strings]...okay!
  28. Check for system calls to replace by KDE or Qt equivalents [syscalls]...okay!
  29. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!
• For File Type kpartgui
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check validity of i18n calls [i18ncheckarg]...okay!
  4. Check for URLs not using transport encryption [insecurenet]...okay!
  5. Check for spelling errors [spelling]...okay!
  6. Validates kpartgui files using 'xmllint' [validate]...okay!
• For File Type designer
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]...okay!
  4. Check validity of i18n calls [i18ncheckarg]...okay!
  5. Check for URLs not using transport encryption [insecurenet]...okay!
  6. Check for spelling errors [spelling]...okay!
• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for problems with filenames [filenames]...okay!
  3. Check for invalid icon names [iconnames]...okay!
  4. Check for URLs not using transport encryption [insecurenet]...okay!
  5. Check for spelling errors [spelling]...okay!
  6. Validates desktop files using 'desktop-file-validate' [validate]...okay!
• For File Type svg
  1. Check for problems with filenames [filenames]...okay!
  2. Validate uncompressed SVG files using 'xmllint' [validate]...okay!